Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: go release tag fails semver version check #280

Closed
flowchartsman opened this issue Aug 13, 2023 · 2 comments
Closed

Tracking issue: go release tag fails semver version check #280

flowchartsman opened this issue Aug 13, 2023 · 2 comments

Comments

@flowchartsman
Copy link

flowchartsman commented Aug 13, 2023

I created an issue that ended up as golang/go#61692, which involved RC version numbers failing gofumpt's semver check when attempting to determine minimal go version. This issue was resolved from the gopls side by massaging the version number before passing to gofumpt, and the issue was closed, however it was unclear from the discussion whether @mvdan would want to make doc or code modifications to gofumpt as a result, and I didn't find any followup from @findleyr on putative updates to x/mod so I thought I'd open this issue so the discussion didn't get lost.

Feel free to close if unnecessary!

@flowchartsman flowchartsman changed the title Tracking issue: go release tag to semver for version check Tracking issue: go release tag fails semver version check Aug 13, 2023
@mvdan
Copy link
Owner

mvdan commented Aug 15, 2023

Thanks for filing this - indeed it's on my mind, and we should have a tracking issue here.

I've raised golang/go#62039 to properly track the upstream feature request.

@findleyr
Copy link

Thanks both. Indeed, I hadn't gotten around to filing an issue, and appreciate your tracking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants