Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"mvdan.cc/sh/v3: no Go source files" on go get #703

Closed
zikaeroh opened this issue May 18, 2021 · 1 comment
Closed

"mvdan.cc/sh/v3: no Go source files" on go get #703

zikaeroh opened this issue May 18, 2021 · 1 comment
Milestone

Comments

@zikaeroh
Copy link

I did an update in a project that uses this module; my handy update script just requests each directly required module @latest. The recent addition of a package at the top level without any buildable files (since the one file is guarded by a build tag) makes go get unhappy:

$ go get -d mvdan.cc/sh/v3@latest              
mvdan.cc/sh/v3: no Go source files

Does the root directory need an unguarded file to ensure that the package is buildable, or maybe have its code moved to some other directory?

@mvdan
Copy link
Owner

mvdan commented May 18, 2021

You're right, and I can reproduce on 1.16.4. This seems to be golang/go#33526, which in theory did get fixed in 1.16.x, but I still see the error. I left a comment there.

It seems like this bug is fixed on Go master as of go version devel go1.17-ce92a2023c Sat May 15 02:39:08 2021 +0000 linux/amd64, as I can no longer reproduce. But I'll add a workaround since 1.15.x and 1.16.x might suffer from this bug for a while still.

@mvdan mvdan closed this as completed in 7603a0c May 19, 2021
@mvdan mvdan added this to the 3.3.1 milestone Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants