Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title check does not trigger when <head> is empty and right next to </head> #8

Closed
ecerta opened this issue Jan 5, 2019 · 1 comment
Closed

Title check does not trigger when <head> is empty and right next to </head> #8

ecerta opened this issue Jan 5, 2019 · 1 comment
Assignees
@mvdschee
Labels
bug Something isn't working

Comments

@ecerta
Copy link
Contributor

ecerta commented Jan 5, 2019 •
edited

Describe the bug
The check to be sure there is a <title> attribute between <head> tags does not trip if the <head> tags are empty and right next to each other.

To Reproduce

Expected behavior
The linter should trip when <header> tags are empty and consecutive.

Screenshots
If applicable, add screenshots to help explain your problem.
consecutive opening and closing head tags with no title attribute. No linter underline.

Note: Anything at all separating <head> tags, including space or newline, does trip the linter.
consecutive opening and closing head tags with no title attribute, this time with a space between. Linter underline present.

Visual Studio Code (please complete the following information):

  • Version 1.29.1

Additional context
This will probably be a pretty rare problem since most devs do make use of the <header> space for one thing or another if not <title> tags, but it's a fun edge case to put to bed.
@mvdschee mvdschee added the bug Something isn't working label Jan 7, 2019
@mvdschee mvdschee self-assigned this Jan 7, 2019
@mvdschee
Copy link
Owner

mvdschee commented Jan 7, 2019

@ecerta Thanks for pointing that out, something I probably overlooked while using autocomplete. I think it's indeed a rare edge case but still, a bug that needs to be squeezed!

@mvdschee mvdschee mentioned this issue Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvdschee mvdschee

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecerta @mvdschee