Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources jar contains only asm sources #349

Closed
sneudert opened this issue Dec 19, 2023 · 5 comments
Closed

Sources jar contains only asm sources #349

sneudert opened this issue Dec 19, 2023 · 5 comments
Assignees

Comments

@sneudert
Copy link

In mvel2-2.5.0.Final-sources.jar, only the sources of package org.mvel2.asm are contained (the sources of org.objectweb.asm with unsubstituted package name). this makes debugging awkward.

  • setting false for maven-shade-plugin fixes this.
@jdimeo
Copy link

jdimeo commented Mar 27, 2024

I just noticed this too! Still present in 2.5.2

@jdimeo
Copy link

jdimeo commented Mar 27, 2024

Related to changes in #330

@tkobayas
Copy link
Collaborator

Thank you for reporting, and sorry for replying late. It's surprising that maven-shade-plugin creates a source jar which contains only dependencies' sources, not the project sources. As @sneudert wrote, setting <createSourcesJar>false</createSourcesJar> produces a source jar with the project source codes (but without the relocated asm sources).

I'll investigate if I can create a source jar contains both sources.

@tkobayas
Copy link
Collaborator

Maven mailing list greatly helped :)
https://lists.apache.org/thread/47bq292myz44rr0j8g75t2lpnvbs93fp

We just need to change the order of maven-source-plugin and maven-shade-plugin.

Filed a PR : #358

@tkobayas
Copy link
Collaborator

tkobayas commented Apr 2, 2024

Fixed by #358

@tkobayas tkobayas closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants