Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop a way that verifies if all attributes are visited by the Dot visitor #112

Open
mvgijssel opened this issue Jul 30, 2019 · 0 comments
Labels
enhancement New feature or request
Projects
Milestone

Comments

@mvgijssel
Copy link
Owner

In #106 lib/arel/extensions/select_statement.rb some additional visit_edge calls were added. Not implementing these calls currently goes unnoticed, as only implemented calls are verified for correctness.

Let's see if there's a way to extend spec/support/visitors.rb:19 to verify if all attributes of an object are actually visited by the Dot visitor (and raise an exception if this is not the case).

@mvgijssel mvgijssel added the enhancement New feature or request label Jul 30, 2019
@mvgijssel mvgijssel added this to the 0.5.0 milestone Jul 30, 2019
@mvgijssel mvgijssel added this to To do in testing via automation Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
testing
  
To do
Development

No branches or pull requests

1 participant