Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPDB error when updating https_unsecure_external_urls #25

Open
dave1010 opened this issue Dec 6, 2013 · 2 comments
Open

WPDB error when updating https_unsecure_external_urls #25

dave1010 opened this issue Dec 6, 2013 · 2 comments

Comments

@dave1010
Copy link

dave1010 commented Dec 6, 2013

I've just got this error message in version 3.3.0 (I've trimmed about 1MB of serialised array data from the SQL):

WordPress database error Got a packet bigger than 'max_allowed_packet' bytes for query UPDATE `wp_options` SET `option_value` = '..............................' WHERE `option_name` = 'wordpress-https_unsecure_external_urls' made by require('wp-blog-header.php'), require_once('wp-includes/template-loader.php'), do_action('template_redirect'), call_user_func_array, WordPressHTTPS_Module_Core->redirect_check, WordPressHTTPS->redirect, WordPressHTTPS->makeUrlHttps, WordPressHTTPS->addUnsecureExternalUrl, Mvied_Plugin->setSetting, update_option

This pushes the query over the limit (which caused error logs to grow at 2MB/s and the server's CPU to spike). I can increase the limit but it seems strange that the plugin is trying to update that much data. It looks like there's about 4000 URLs in the option_value, which I would have thought would be much less than 1MB.

Is this the expected behaviour or have I set something up wrongly?

@jorrit
Copy link

jorrit commented Nov 1, 2014

I think this behavior is the way this plugin works. It was not built with this many URLs in mind, I think. The maintainer should move the secure/unsecure external urls to a table. This will make lookups and storage much more scalable.

@headstash headstash added this to To Do in 3.5.0 via automation Dec 29, 2017
@headstash headstash self-assigned this Dec 29, 2017
@headstash
Copy link
Collaborator

The latest version (3.4.1) may address these issues, but I have not implemented the database caching in this version.

@headstash headstash removed their assignment May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.5.0
  
To Do
Development

No branches or pull requests

3 participants