Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off mouse activity? #14

Closed
lmonson opened this issue Jun 12, 2014 · 5 comments
Closed

Option to turn off mouse activity? #14

lmonson opened this issue Jun 12, 2014 · 5 comments

Comments

@lmonson
Copy link
Contributor

lmonson commented Jun 12, 2014

I'm using panzoom in a project where, on one screen, the zoom effect is to be controlled exclusively by external controls and not by mouse activity (e.g. scroll wheel).

Would you be interested in a pull request that implements the option to turn off some of the mouse activity in panzoom ?

@mvindahl
Copy link
Owner

Hello lmonson,

I think that would make good sense. Maybe we should have separate options to turn off mouse wheel zoom and click-and-drag pan, respectively. In any case it seems like a nice enhancement even if it's just the first step and I'll be happy to accept your pull request.

Regards,
/Martin

@askarby
Copy link
Collaborator

askarby commented Jun 13, 2014

I would like to get that pull-request in, and at a later point in time add further customization options.

@mvindahl
Copy link
Owner

Agreed. It's a step in the right direction either way and we might as well get it in before we do the 0.9 release.

On a side note, starting at v1.0 we're planning a small but breaking change to how the API is published. Any comments will be appreciated at this point, especially from lmonson.

lmonson, I'm asking you this favor since you are rolling your own external controls, meaning that you obviously understand both angularJS and the panzoom project. I'm trying to minimize the impact but you will need to make changes to your code when upgrading to 1.0 (sorry!). Still I feel that this is an issue that I need to fix; the current approach is very ad hoc and was just a quick and dirty way to make things work during the initial phase.

So if you have the time to spare, please have a look here:
#11

@lmonson
Copy link
Contributor Author

lmonson commented Jun 17, 2014

I think this issue can be closed as it is a duplicate of the closed pull request
#17

@mvindahl
Copy link
Owner

True. Thanks for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants