Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab_ci_pipeline_time_since_last_run_seconds not updated, when ref was deleted #150

Closed
krebs-GVL opened this issue Oct 7, 2020 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@krebs-GVL
Copy link

Hi,

This may be the same as #119
I realized, that gitlab_ci_pipeline_time_since_last_run_seconds will not get updated for merge request pipelines, if the merge request was deleted. I expect, that this also happens with branch refs.

I can only provide a screenshot from a custom dashboard

grafik

It is sorted by ID, so the most recent is on top. The eternal branches develop and master shows the correct values, but the merge request refs shows the exact time it took from pipeline completion to merge/delete.

Maybe a timestamp instead of a duration is more reliable?

@mvisonneau
Copy link
Owner

mvisonneau commented Oct 7, 2020

👋 hey @krebs-GVL, indeed, this is something that I wanted to do for a while, I just pushed it as part of a broader metric naming update (26ddfe8). It will be part the next release. You will therefore be able to use time() - gitlab_ci_pipeline_timestamp to compute the value dynamically in prometheus.

@mvisonneau mvisonneau self-assigned this Oct 7, 2020
@mvisonneau mvisonneau added bug Something isn't working enhancement New feature or request labels Oct 7, 2020
@mvisonneau
Copy link
Owner

These changes are part of the 0.4.0 release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants