Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a homebrew package #106

Closed
ppalaga opened this issue Oct 19, 2020 · 11 comments
Closed

Provide a homebrew package #106

ppalaga opened this issue Oct 19, 2020 · 11 comments
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Oct 19, 2020

like ist is done in jbang

cc @chirino

@michael-simons
Copy link

I am a happy home-brew user and here's a shot at it:

https://github.com/michael-simons/homebrew-mvnd

Feel free to take it and incorporate it into mvnd.

The test executes nicely and apart from being a binary dist, it should fulfill brews audit.
Maven itself is setup similar, so that should be that big problem.

Anyway, thanks for a great project! Cheers.

@michael-simons
Copy link

(The tap is Mac only atm).

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 24, 2020

Much appreciated, thanks a lot, @michael-simons!

Would you like to transfer the ownership of your repo to the mvndaemon github org? I hope @gnodet is not against that.
I'd make you a committer in the new repo if you are interested.

@michael-simons
Copy link

Sure thing, but I can't. Guess I must be a committer first.

You don’t have the permission to create public repositories on mvndaemon

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 25, 2020

You don’t have the permission to create public repositories on mvndaemon

Should be fixed now

@michael-simons
Copy link

Thanks, Peter! This is a highlight of my day! Ownership transferred, readme fixed.

I have one 10.13.6 Mac here that gives me socket time out… Something I'm gonna investigate today. 3 machines work just fine, on that particular one the daemon starts but the client can't connect.

Anyway: Thanks a lot for mvnd, I find this incredible useful.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 25, 2020

Perfect, thanks!

We should now add some code into our GH actions pipeline to auto-update the tap on release.

@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 25, 2020

This mvnd release task

https://github.com/mvndaemon/mvnd/blob/master/.github/workflows/verify.yaml#L277-L285

should now be able to trigger the homebrew update

https://github.com/mvndaemon/mvnd/blob/master/.github/workflows/verify.yaml#L277-L285

I tested the trigger manually but we'll only see during our next release whether it works really.

@ppalaga ppalaga closed this as completed Oct 25, 2020
@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 26, 2020

0.0.10 was not 100% successful. I had to add one more fix mvndaemon/homebrew-mvnd@3a922e4
I hope 0.0.11 will run flawlessly incl. the homebrew tap.

@ppalaga ppalaga added this to the 0.0.11 milestone Oct 29, 2020
@ppalaga
Copy link
Contributor Author

ppalaga commented Oct 29, 2020

Yeah, the homebrew tap update worked flawlessly during the 0.0.11 release.

@michael-simons
Copy link

Great!

Also, my Neo4j-OGM issues disappeared with 0.0.11 (the ones with the large output).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants