Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to default to a simple log when using a single thread #116

Closed
famod opened this issue Oct 20, 2020 · 8 comments · Fixed by #204
Closed

Option to default to a simple log when using a single thread #116

famod opened this issue Oct 20, 2020 · 8 comments · Fixed by #204
Labels
enhancement New feature or request
Milestone

Comments

@famod
Copy link
Contributor

famod commented Oct 20, 2020

It would come in handy to able to opt-out of the log buffering in case you want a more default maven output, e.g. to compare runs to mvn in case mvnd is showing unexpected behaviour.
When building Quarkus with its 700+ modules, console can also become unresponsive for a while when everything is flushed at once at the end of the build.

@gnodet
Copy link
Contributor

gnodet commented Oct 21, 2020

Hitting the <enter> key or Ctrl+M should mitigate this behaviour as the output of each module will be displayed once it has been built. It could changed to be the default behavior... Can you give it a try ?

@famod
Copy link
Contributor Author

famod commented Oct 22, 2020

Hitting the <enter> key or Ctrl+M should mitigate this behaviour as the output of each module will be displayed once it has been built.

Confirmed, thanks!

It could changed to be the default behavior...

Well, if I would see the condensed status as described in README (which I don't, maybe because of #36?), then I would actually prefer the less noisy mode to be the default.
Ideally there should be a command line argument to switch to the more noisy mode und the icing on the cake would be if the default could be configured in a config file (which the command line argument would override if present).

Btw, is there something like MVND_OPTS (analogous to MAVEN_OPTS)?

@jglick
Copy link
Contributor

jglick commented Oct 22, 2020

I would really like to opt out of the custom display (which by the way is broken in Emacs’ M-x shell), and the implicit -T, so that the behavior is as similar to mvn as possible.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 23, 2020

I would really like to opt out of the custom display (which by the way is broken in Emacs’ M-x shell

Could you please file a separate issue?

), and the implicit -T, so that the behavior is as similar to mvn as possible.

Could you please file a separate issue in which you explain why?

@jglick
Copy link
Contributor

jglick commented Oct 23, 2020

Another reason to want output to be displayed normally as it arrives: watching the progress of tests. I actually rolled back a Surefire update just because it broke this: jenkinsci/plugin-pom#343

@gnodet gnodet added the enhancement New feature or request label Oct 26, 2020
@gnodet
Copy link
Contributor

gnodet commented Oct 26, 2020

@jglick the progress can also be seen in more details if you hit the '+' key 3/4 times during the build... (hit '-' to get revert).
It will display the last few lines for each module

@famod famod changed the title Opt-out of "Improved console output" Opt out of "Improved console output" Oct 29, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Nov 11, 2020

I wonder, if we could automatically stretch the rolling log to the full screen in case there is just a single thread running?

@gnodet
Copy link
Contributor

gnodet commented Nov 11, 2020

@ppalaga I was thinking about:

  • having an option to just display the events when they come (prefixed by the projectId to make it more understandable), this would be when running on a dumb terminal Better support for dumb terminals #131
  • having an option to default to a simple log when using a single thread (i.e. just print the events when they come as maven does) Option to default to a simple log when using a single thread #116
  • make the default rolling window size configurable (it currently defaults to 0, but it could be raised a bit by default, not sure)

Maybe the first two can be the same. It's just that we add the prefix if the build has a max number of threads > 1.

@gnodet gnodet changed the title Opt out of "Improved console output" Option to default to a simple log when using a single thread Nov 11, 2020
gnodet added a commit to gnodet/mvnd that referenced this issue Nov 11, 2020
@ppalaga ppalaga added this to the 0.0.12 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants