Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement build cancellation #127

Closed
gnodet opened this issue Oct 22, 2020 · 2 comments · Fixed by #199
Closed

Implement build cancellation #127

gnodet opened this issue Oct 22, 2020 · 2 comments · Fixed by #199
Assignees
@gnodet
Labels
new feature
Milestone
0.0.12

Comments

@gnodet
Copy link
Contributor

gnodet commented Oct 22, 2020

Some support is already provided (such as a specific state and such) but we need to intercept the Ctrl+C / interrupt event, send a cancellation request and check on the daemon side.
@famod
Copy link
Contributor

famod commented Oct 22, 2020

This would be a useful enhancement!
I ran mvnd --debug today and aborted it right away with ctrl+c but it took maybe 10-20 secs until cpu load of the daemon dropped from > 90% back to zero.

@ppalaga ppalaga mentioned this issue Oct 25, 2020
Closed
@herder
Copy link

herder commented Oct 26, 2020 •
edited

Also when pressing Ctrl-C to cancel a job, the Maven output so far is not given.

It would be great to get the output that has been produced by Maven, and possibly an opt-out setting if we want the current behavior.

@gnodet gnodet added enhancement New feature or request new feature and removed enhancement New feature or request labels Oct 29, 2020
@gnodet gnodet self-assigned this Nov 6, 2020
gnodet added a commit to gnodet/mvnd that referenced this issue Nov 9, 2020
@gnodet
Implement build cancellation, fixes apache#127
9478715
gnodet added a commit to gnodet/mvnd that referenced this issue Nov 9, 2020
@gnodet
Implement build cancelation, fixes apache#127
9cfdc6d
ppalaga pushed a commit to ppalaga/mvnd that referenced this issue Nov 10, 2020
@gnodet @ppalaga
Implement build cancelation, fixes apache#127
5c81bce
@ppalaga ppalaga mentioned this issue Nov 10, 2020
Merged
ppalaga pushed a commit to ppalaga/mvnd that referenced this issue Nov 10, 2020
@gnodet @ppalaga
Implement build cancelation, fixes apache#127
98c91af
ppalaga pushed a commit to ppalaga/mvnd that referenced this issue Nov 10, 2020
@gnodet @ppalaga
Implement build cancelation, fixes apache#127
c52dfa3
ppalaga pushed a commit that referenced this issue Nov 10, 2020
@gnodet @ppalaga
Implement build cancelation, fixes #127
0800aeb
@ppalaga ppalaga added this to the 0.0.12 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnodet gnodet

Labels
new feature
Projects
None yet
Milestone
0.0.12
Development

Successfully merging a pull request may close this issue.

Implement build cancelation ppalaga/mvnd
4 participants
@gnodet @herder @ppalaga @famod