Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let -h/--help display also mvnd specific options #243

Closed
ppalaga opened this issue Dec 8, 2020 · 4 comments · Fixed by #244
Closed

Let -h/--help display also mvnd specific options #243

ppalaga opened this issue Dec 8, 2020 · 4 comments · Fixed by #244
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Dec 8, 2020

No description provided.

@ppalaga ppalaga added the enhancement New feature or request label Dec 8, 2020
@ppalaga ppalaga self-assigned this Dec 8, 2020
ppalaga added a commit to ppalaga/mvnd that referenced this issue Dec 8, 2020
@gnodet
Copy link
Contributor

gnodet commented Dec 8, 2020

@ppalaga The default line length of 80 is really ugly. The client uses JLine, so we do have the terminal width and we should send it to the daemon to properly format the help. We could add a getTerminalWidth method to the ClientOutput for that and it could be sent as a system property to the daemon (an internal property such as mvnd.terminalWidth). I'll work on that bit if you want.

Also, we should add a way to document the command line options such as --start, --stop and --status somehow as they seem to be missing from the help.

@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 8, 2020

@ppalaga The default line length of 80 is really ugly.

I agree, and it is even less: 74. I just took the format used by the the stock mvn --help.

The client uses JLine, so we do have the terminal width and we should send it to the daemon to properly format the help. We could add a getTerminalWidth method to the ClientOutput for that and it could be sent as a system property to the daemon (an internal property such as mvnd.terminalWidth). I'll work on that bit if you want.

+1, that would be awesome.

Also, we should add a way to document the command line options such as --start, --stop and --status somehow as they seem to be missing from the help.

Yes, that's not so hard. I plan to work on that.

@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 8, 2020

Is this good to merge then?

@gnodet
Copy link
Contributor

gnodet commented Dec 8, 2020

@ppalaga I'm working on the terminal width, but if you want to merge before, that's fine with me.

@gnodet gnodet added this to the 0.1.2 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants