Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differences between mvn clean install and mvnd clean install #25

Closed
maxandersen opened this issue May 5, 2020 · 5 comments
Closed

differences between mvn clean install and mvnd clean install #25

maxandersen opened this issue May 5, 2020 · 5 comments
Milestone

Comments

@maxandersen
Copy link

I used mvnd clean install -DskipTests -DskipITs -Dquarkus.build.skip -DskipDocs -Denforcer.skip twice in quarkus root now and both times I don't seem to end up with jars/classes in the ~/.m2 repo that corresponds to what mvn clean install brings.

The way I realize there is an issue is that breakpoints were not being hit and main diff was that newly updated code from a pull request did not seem to be included in the build.

My best guess is that mvnd might do some time comparison and the PR's files are from before last build thus they are not included in the build or something similar ?

I wish I could be more precise :)

@ppalaga
Copy link
Contributor

ppalaga commented May 6, 2020

I have found another issue when trying to dig into this one: https://github.com/gnodet/mvnd/issues/26

@ppalaga
Copy link
Contributor

ppalaga commented May 6, 2020

In case this is really caused by malfunctioning classloader cache, as suggested by @gnodet in #26 then the issue can be workarounded by killing the daemon mvnd --stop each time you change code loaded by some of the quarkus plugins.

@ppalaga
Copy link
Contributor

ppalaga commented May 11, 2020

It seems like mvnd is not picking the changes in camel-quarkus-bom. Let me properly record the steps to reproduce next time I see it.

@ppalaga
Copy link
Contributor

ppalaga commented Jun 28, 2020

mvnd is indeed malfunctioning when there is a Mojo in the source tree and it is used in another module. #33 links a reproducer. We have such a situation in Quarkus, so this may well be a root cause of what @maxandersen sees.

I still have to check if changes in BOM are picked.

@ppalaga
Copy link
Contributor

ppalaga commented Jul 31, 2020

Closing as the plugin classloader cache invalidation issue should be solved as of mvnd 0.0.1 (see https://github.com/mvndaemon/mvnd/releases/tag/0.0.1 ) and I have not seen any issue related to changes in BOM for some time now.

@maxandersen thanks for the report and looking forward for new reports if you give mvnd the second chance!

@ppalaga ppalaga closed this as completed Jul 31, 2020
@ppalaga ppalaga added this to the 0.0.1 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants