Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Maven 3.8.1 #393

Closed
robertklaus-bosch opened this issue Apr 7, 2021 · 9 comments · Fixed by #394
Closed

Support Maven 3.8.1 #393

robertklaus-bosch opened this issue Apr 7, 2021 · 9 comments · Fixed by #394
Milestone

Comments

@robertklaus-bosch
Copy link

Maven 3.8.1 has been released with some fixes for CVEs:
https://maven.apache.org/docs/3.8.1/release-notes.html

Would it be possible to support this?

@ppalaga
Copy link
Contributor

ppalaga commented Apr 7, 2021

Yes, definitely. Somebody just has to find a couple of free cycles for that :)

@robertklaus-bosch
Copy link
Author

Let me guess, there is more to do than bumping up the maven.version in the pom.xml 😉
Any pointers what would need to be done for this?

@ppalaga
Copy link
Contributor

ppalaga commented Apr 7, 2021

It's bumping and seeing what got broken 8-)

@robertk3s
Copy link
Contributor

Damn. Check on darwin fails with compilation error. Could need a hint what went wrong here.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 7, 2021

Damn. Check on darwin fails with compilation error. Could need a hint what went wrong here.

The error message sounds like some variant of #281 I have restarted the jobs to see if it happens again.

@robertk3s
Copy link
Contributor

@ppalaga thanks for the support. Restarting the checks helped, they passed now!

@robertk3s
Copy link
Contributor

@ppalaga , @gnodet how are we going to proceed with this now?

@robertk3s
Copy link
Contributor

@gnodet wrote on the puill request:

Given 3.8.1 creates some incompatibilities, I'd really like to get the time to work on supporting multiple maven versions as indicated by #143 .

I can totally understand the wish to support multiple versions. I'm not so experienced with GitHub Actions, just thinking that basically it is possible to set the Maven version with -Dmaven.version and do the build again (+ setting a version on the binaries).
Might be doable with this maybe:
https://github.blog/changelog/2020-08-07-github-actions-composite-run-steps/ ?

Or the simply a branch with the 3.6.x and one with the 3.8.x .. that would be simple, but has some disadvantages of course.

What do you think?

@gnodet
Copy link
Contributor

gnodet commented Apr 14, 2021

@gnodet wrote on the puill request:

Given 3.8.1 creates some incompatibilities, I'd really like to get the time to work on supporting multiple maven versions as indicated by #143 .

I can totally understand the wish to support multiple versions. I'm not so experienced with GitHub Actions, just thinking that basically it is possible to set the Maven version with -Dmaven.version and do the build again (+ setting a version on the binaries).
Might be doable with this maybe:
https://github.blog/changelog/2020-08-07-github-actions-composite-run-steps/ ?

Or the simply a branch with the 3.6.x and one with the 3.8.x .. that would be simple, but has some disadvantages of course.

What do you think?

Yes, I'm now thinking that's the best way forward.

gnodet pushed a commit to gnodet/mvnd that referenced this issue Apr 27, 2021
@gnodet gnodet added this to the 0.5.0 milestone Apr 27, 2021
gnodet pushed a commit to gnodet/mvnd that referenced this issue Apr 27, 2021
gnodet pushed a commit to gnodet/mvnd that referenced this issue Apr 28, 2021
gnodet pushed a commit to gnodet/mvnd that referenced this issue Apr 28, 2021
gnodet added a commit that referenced this issue Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants