Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot clean on Windows as long as mvnd keeps a plugin from the tree loaded #40

Closed
ppalaga opened this issue Jun 30, 2020 · 2 comments · Fixed by #45
Closed

Cannot clean on Windows as long as mvnd keeps a plugin from the tree loaded #40

ppalaga opened this issue Jun 30, 2020 · 2 comments · Fixed by #45
Milestone
0.0.1

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Jun 30, 2020

Reproducible by adding clean to the second invocation of client.execute() in ModuleAndPluginNativeIT.

This is because the test project uses a plugin which is compiled from sources in the same source tree. Windows does not allow deleting open file, so as long as mvnd keeps the plugin jar open, it cannot be cleaned/deleted.
@gnodet
Copy link
Contributor

gnodet commented Jun 30, 2020

We should improve the CliPluginRealmCache to get rid of realms for plugins build in the reactor after (or before) a project build somehow.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 30, 2020

Yeah, I thought of that too.

ppalaga added a commit to ppalaga/mvnd that referenced this issue Jul 29, 2020
@ppalaga
Fix apache#40 Cannot clean on Windows as long as mvnd keeps a plugin …
cbfab47 
…from the tree loaded
@ppalaga ppalaga mentioned this issue Jul 29, 2020
Merged
ppalaga added a commit to ppalaga/mvnd that referenced this issue Jul 29, 2020
@ppalaga
Fix apache#40 Cannot clean on Windows as long as mvnd keeps a plugin …
3d39796 
…from the tree loaded
ppalaga added a commit that referenced this issue Jul 29, 2020
@ppalaga
Merge pull request #45 from ppalaga/i40
8fd2234 
Fix #40 Cannot clean on Windows as long as mvnd keeps a plugin from t…
@ppalaga ppalaga added this to the 0.0.1 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.1
Development

Successfully merging a pull request may close this issue.

Fix #40 Cannot clean on Windows as long as mvnd keeps a plugin from t… ppalaga/mvnd
2 participants
@gnodet @ppalaga