Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List mvnd on sdkman.io #48

Closed
ppalaga opened this issue Jul 31, 2020 · 14 comments
Closed

List mvnd on sdkman.io #48

ppalaga opened this issue Jul 31, 2020 · 14 comments
Assignees
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Jul 31, 2020

Citing @gastaldi:

it would be nice to have it listed in sdkman.io

Volunteers?

@helpermethod
Copy link

Hi, would love to help out!

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 10, 2020

Thanks, @helpermethod !

@marc0der
Copy link

This certainly looks doable, but would require standard application zip archives to be built for each platform. This could be done using the maven assembly plugin (as the project seems to be built with maven).

@helpermethod
Copy link

helpermethod commented Aug 10, 2020

If it's okay for @ppalaga I would add the missing build step.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 10, 2020

Yes, of course, adding maven assembly plugin is OK.

The question is whether we should keep publishing the plain (non-zipped) mvnd client executables on GH releases as we do today?

The non-zipped mvnd client executables might be seen as easier to install for the people who do not want or can't use sdkman. OTOH, installing from the zipped ones is just one step more to document in the README. What do others think?

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 10, 2020

The question is whether we should keep publishing the plain (non-zipped) mvnd client executables on GH releases as we do today?

That's actually related but separate issue. We do not need to solve it here. But for the record: I would not mind if we stop publishing the non-zipped clients.

@helpermethod
Copy link

helpermethod commented Aug 10, 2020

The native image is now packaged into a ZIP archive. Wasted endless hours trying to make the provisio-maven-plugin work but finally gave up and used the maven-assembly-plugin 😭 .

I've also added additional steps to the GitHub workflow.

@ppalaga
Copy link
Contributor Author

ppalaga commented Aug 15, 2020

The zip files in https://github.com/mvndaemon/mvnd/releases/tag/0.0.3 should comply with the requirements of sdkman. What do we need to do next?

@helpermethod
Copy link

helpermethod commented Aug 15, 2020

Hi,

a PR for a DB migration needs to be created at https://github.com/sdkman/sdkman-db-migrations.

You basically need to add a migration script under

https://www.github.com/sdkman/sdkman-db-migrations/tree/master/src%2Fmain%2Fscala%2Fio%2Fsdkman%2Fchangelogs

according to the rules laid out in the README.md.

@helpermethod
Copy link

helpermethod commented Sep 3, 2020

Hi @ppalaga,

got a little bit of time today and will add mvnd to SDKMAN! as a candidate.

@helpermethod
Copy link

helpermethod commented Sep 3, 2020

Hi @ppalaga,

the PR got successfully merged, sorry for waiting so long.

image
image

@helpermethod
Copy link

BTW future versions of mvnd could be published via the Vendor API.

JBang and others do this too.

@helpermethod
Copy link

Hi @ppalaga, can we close this?

@ppalaga
Copy link
Contributor Author

ppalaga commented Sep 16, 2020

Great work, thanks @helpermethod !

@ppalaga ppalaga closed this as completed Sep 16, 2020
@ppalaga ppalaga added this to the 0.0.5 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants