-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List mvnd on sdkman.io #48
Comments
Hi, would love to help out! |
Thanks, @helpermethod ! |
This certainly looks doable, but would require standard application zip archives to be built for each platform. This could be done using the maven assembly plugin (as the project seems to be built with maven). |
If it's okay for @ppalaga I would add the missing build step. |
Yes, of course, adding maven assembly plugin is OK. The question is whether we should keep publishing the plain (non-zipped) mvnd client executables on GH releases as we do today? The non-zipped mvnd client executables might be seen as easier to install for the people who do not want or can't use sdkman. OTOH, installing from the zipped ones is just one step more to document in the README. What do others think? |
That's actually related but separate issue. We do not need to solve it here. But for the record: I would not mind if we stop publishing the non-zipped clients. |
The native image is now packaged into a ZIP archive. Wasted endless hours trying to make the I've also added additional steps to the GitHub workflow. |
The zip files in https://github.com/mvndaemon/mvnd/releases/tag/0.0.3 should comply with the requirements of sdkman. What do we need to do next? |
Hi, a PR for a DB migration needs to be created at https://github.com/sdkman/sdkman-db-migrations. You basically need to add a migration script under according to the rules laid out in the README.md. |
Hi @ppalaga, got a little bit of time today and will add |
Hi @ppalaga, the PR got successfully merged, sorry for waiting so long. |
BTW future versions of
|
Hi @ppalaga, can we close this? |
Great work, thanks @helpermethod ! |
Citing @gastaldi:
Volunteers?
The text was updated successfully, but these errors were encountered: