Improvements #124
Merged
Improvements #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
famod
reviewed
Oct 22, 2020
client/src/main/java/org/jboss/fuse/mvnd/client/DaemonConnector.java
Outdated
Show resolved
Hide resolved
famod
reviewed
Oct 22, 2020
|
FYI: I cherry-picked 0656e13 (loopback address), fixed the imports and tried out the native image that was built in my fork and it does fix the VPN problem for me! 🎉 👍 /cc @ppalaga |
Merged
ppalaga
reviewed
Oct 22, 2020
| @@ -144,7 +144,7 @@ private void handleStopEvents(Collection<DaemonInfo> idleDaemons, Collection<Dae | |||
| stopEvent.getUid(), stopEvent.getTimestamp(), stopEvent.getReason()); | |||
| } | |||
|
|
|||
| LOGGER.debug(generate(busyDaemons.size(), idleDaemons.size(), recentStopEvents.size())); | |||
| System.out.println(generate(busyDaemons.size(), idleDaemons.size(), recentStopEvents.size())); | |||
There was a problem hiding this comment.
Why System.out and not LOGGER.info() ?
There was a problem hiding this comment.
Mainly to avoid the [INFO] prefix on the line.
ppalaga
approved these changes
Oct 22, 2020
Thanks for helping and great that it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.