Minor improvements #203
Minor improvements #203
Conversation
| @@ -232,7 +232,7 @@ public DaemonClientConnection startDaemon() { | |||
| return daemonConnection; | |||
| } | |||
| try { | |||
| sleep(200L); | |||
| sleep(10L); | |||
There was a problem hiding this comment.
Why do we need to sleep here actually?
There was a problem hiding this comment.
While the daemon is created, the registry does not contain any info, so the client would loop and read the registry continuously. But reading the registry involves complex file operations locking, so we need to let the daemon some space to actually write its own state to the registry.
It would be interesting to know how many iterations it takes on fast laptops.
There was a problem hiding this comment.
@ppalaga it's usually around 900ms / 1000ms to connect to a new daemon (the time between the start in this loop and the return statement), so it may be safer to revert to 200L to not consume too much cpu on not too fast computers.
No description provided.