Fix display showing more projects than the ones actually active #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
reviewed
Feb 23, 2021
| @@ -430,7 +430,7 @@ private void cancelNow() { | |||
| private void handle(DaemonConnection connection, BuildRequest buildRequest) { | |||
| updateState(Busy); | |||
| final BlockingQueue<Message> sendQueue = new PriorityBlockingQueue<>(64, | |||
| Comparator.comparingInt(this::getClassOrder).thenComparingLong(Message::timestamp)); | |||
There was a problem hiding this comment.
If you really wanted to remove getClassOrder from the comparator, then the getClassOrder() method can be removed too.
And we perhaps also do not need a PriorityBlockingQueue anymore.
ppalaga
reviewed
Feb 23, 2021
| @@ -279,8 +281,8 @@ private boolean doAccept(Message entry) { | |||
| Project prj = projects.remove(artifactId); | |||
| if (prj != null) { | |||
| prj.log.forEach(log); | |||
| doneProjects.add(artifactId); | |||
There was a problem hiding this comment.
Why do we need doneProjects set? Under which circumstances would deliver a different count than the original int doneProjects?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.