Fix display #88
Merged
Fix display #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppalaga
reviewed
Oct 9, 2020
| @@ -0,0 +1,182 @@ | |||
| /* | |||
There was a problem hiding this comment.
Too many license headers in this file. Could you please keep only one original which is further below?
There was a problem hiding this comment.
Not really, I think derivative work is covered by the top license and not licensed to the ASF...
ppalaga
reviewed
Oct 9, 2020
| * probably not really used. | ||
| * | ||
| * @author Jason van Zyl | ||
| * @since 3.1.0 |
There was a problem hiding this comment.
Suggested change
| * @since 3.1.0 |
I guess we can remove @since here
|
|
||
| /** | ||
| * Adapt an SLF4J logger to a Plexus logger, ignoring Plexus logger API parts that are not classical and | ||
| * probably not really used. |
There was a problem hiding this comment.
Suggested change
| * probably not really used. | |
| * probably not really used. | |
| * <p> | |
| * Adapted from * Adapted from https://github.com/apache/maven/blob/maven-3.6.3/maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jLogger.java | |
| @@ -0,0 +1,133 @@ | |||
| /* | |||
There was a problem hiding this comment.
Same issues as with Slf4jLogger.java: licenses, since and link to original
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.