Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework API for SchematicSymbol's libraryIdentifier + libraryName #53

Closed
mvnmgrx opened this issue Feb 18, 2023 · 0 comments · Fixed by #54
Closed

Rework API for SchematicSymbol's libraryIdentifier + libraryName #53

mvnmgrx opened this issue Feb 18, 2023 · 0 comments · Fixed by #54

Comments

@mvnmgrx
Copy link
Owner

mvnmgrx commented Feb 18, 2023

As done in #41, add some code to split the libraryIdentifier into its parts:

  • Remove token libraryIdentifier
  • Add token libraryNickname & entryName
  • Add a setter def id() that accepts some string in the following format: <libraryNickname:>entryName and splits it into its parts via regex
  • Add a getter def id() that returns the library identifier combined from its parts

Furthermore, it was noticed in #46 that a schematic symbol may have a lib_name token assigned to it. This has nothing to do with the library identifier and may be set depending on the number of variations of a modified library symbol in the schematic.

E.g. when copying a symbol and editing it directly in the schematic, the lib_name token will be set to the symbol's <entryName>_X where X is a unique number that specifies which variation this symbol is of its original.

The following has to be done:

  • Add token libraryName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant