Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Frequency Information for Items #735

Closed
Shenkenstein opened this Issue Mar 5, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@Shenkenstein
Copy link

Shenkenstein commented Mar 5, 2017

This would be an enhancement if possible. Another thing I like about the browser extension Rikaisama is its ability to show the frequency information about a word, and it even highlights the numbers different colors depending on how frequent it is (lower = more frequent)
For example:
そう is given frequency number 30.
平和 is given frequency number 2506.
手投弾 is given frequency number 110439.
etc.
This is not super important in terms of priority, I think, but it's definitely useful like in cases when you want to compare words with similar meanings. So if it's not a hassle to add that'd be awesome.

@mvysny mvysny self-assigned this Mar 10, 2017

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Mar 10, 2017

That looks very useful indeed. Could you please attach a screenshot from Rikaisama so that I can get an inspiration? Aedict has access to the frequency information; you can also see the information for yourself when you open the entry details screen and touch the small black-circled i icon, yet having a color visual information about the frequency definitely helps

Also, maybe if you could help me to pick correct colors for frequencies; maybe use these palettes: https://material.io/guidelines/style/color.html#
Or maybe I'll just use this palette? :-D https://d2gne97vdumgn3.cloudfront.net/api/file/fofVDXv1SqqvRoAHZgHe

@Shenkenstein

This comment has been minimized.

Copy link
Author

Shenkenstein commented Mar 10, 2017

Sure, here's an example that seems to show all the colors it uses. It may be less of a gradient and more of a strict cutoff (i.e., 1-4999, 5000-9999, 10000-19999, 20000-). In the end though, I think you should just pick whatever ends up being most intuitive.
image
(the number 1 next to a lot of these is how Rikaisama shows pitch inflection, so don't worry about that number)

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Mar 10, 2017

I'm not sure whether I should use numbers to denote frequency since it's not clear at first sight what that number mean. I'll rather use these words: "rare", "unusual", "regular", "frequent", "common". Please see the screenshot - what do you think?
device-2017-03-10-170959

@Shenkenstein

This comment has been minimized.

Copy link
Author

Shenkenstein commented Mar 10, 2017

I agree that's going to be more pleasing to the average user. The colors will also help solidify the meaning, since to some people, common and frequent may be simply synonyms. Perhaps you could include a setting to change it to the frequency number, for people like myself who would be interested in that detailed information?

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Mar 10, 2017

I'd still prefer to keep things easy. Yet, if you want the exact number, you can open the entry detail and then click the i button. How does this sound?
device-2017-03-10-172711

@Shenkenstein

This comment has been minimized.

Copy link
Author

Shenkenstein commented Mar 10, 2017

Sounds good to me. In fact, that looks great.
I wonder, though, what about words that have no stars on that list. Like 和気あいあい. Do they have a number associated with them at all? I wonder where rikai gets its frequency information.

@mvysny

This comment has been minimized.

Copy link
Owner

mvysny commented Mar 10, 2017

Awesome! Closing the bug, fix will be present in Aedict 3.39.31

@mvysny mvysny closed this Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.