Make comment handler handle dynamic symbols with embedded code

mvz · Jun 22, 2012 · 7318a7e · 7318a7e
1 parent 605fcf0
commit 7318a7e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/lib/ripper_ruby_parser/commenting_sexp_builder.rb b/lib/ripper_ruby_parser/commenting_sexp_builder.rb
@@ -57,6 +57,11 @@ def on_symbol *args
       super
     end
 
+    def on_embexpr_beg *args
+      @in_symbol = false
+      super
+    end
+
     def on_dyna_symbol *args
       @in_symbol = false
       super

diff --git a/test/unit/commenting_sexp_builder_test.rb b/test/unit/commenting_sexp_builder_test.rb
@@ -94,6 +94,20 @@ def parse_with_builder str
                             [:params, nil, nil, nil, nil, nil],
                             [:bodystmt, [[:void_stmt]], nil, nil, nil]]]]]
     end
+
+    it "is not confused by a dynamic symbol containing a class definition" do
+      result = parse_with_builder ":\"foo\#{class Bar;end}\""
+      result.must_equal [:program,
+                         [[:dyna_symbol,
+                           [[:@tstring_content, "foo", [1, 2]],
+                            [:string_embexpr,
+                             [[:comment,
+                               "",
+                               [:class,
+                                [:const_ref, [:@const, "Bar", [1, 13]]],
+                                nil,
+                                [:bodystmt, [[:void_stmt]], nil, nil, nil]]]]]]]]]
+    end
   end
 end