Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block option encoding for 16-bytes blocks #23

Open
chrysn opened this issue Nov 17, 2018 · 0 comments
Open

Block option encoding for 16-bytes blocks #23

chrysn opened this issue Nov 17, 2018 · 0 comments

Comments

@chrysn
Copy link
Contributor

chrysn commented Nov 17, 2018

There's been a bug report in aiocoap about the erroneous encoding of small (16 byte) blockwise options at chrysn/aiocoap#130, and looking at the current txThings code (from whose earlier versions aiocoap originated), I think that https://github.com/mwasilak/txThings/blob/master/txthings/coap.py#L735 is still susceptible to the same problem.

My immediate fix is in chrysn/aiocoap@9bd612d, and should be applicable to txThings in a similar fashion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrysn