-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wheel packaging format for pypi.org #288
Comments
I don't really know anything about wheels, although I understand it makes life easier for people. I'm of course not opposed, but it will take me some time to figure out exactly what to do. I thought wheels were mostly beneficial in the case where a package has compiled code, though, and seaborn is pure python. So that might not be the issue you're seeing? |
conda packages would also be very useful. Should be pretty simple and I can certainly help with that. |
Hi @mwaskom In current state of the wheel, I would say the most immediate benefit is for universal source packages.
You caused my issue with the
of your seaborn-4.4.0 setup.py instead of former seaborn-0.3.1 setup.py
DETAIL EXPLANATION Winpython , when trying to include a SOURCE package .tar.gz or .zip ==> With check_dependencies() , step2 can never succeeds Wheel Advantage1 = step1 and step2 are already done (also reduces the carbon footprint) To include nevertheless seaborn-0.4.0, I'm forced to manually
With a wheel seaborn package
... so my request. I think wheel is 75% of conda functionnality, but for 100% of the (windows/apple) Python world. |
Thanks that makes a lot of sense. You can read #169 and #285 for a full explanation of the changes in I'll try to look more into wheels this weekend. |
The way that works for me is to install every package (carefully listed) with no checks, then turn the light on. As far as I could understand the sometimes 'not super-clear' wheel documentation, we get about the same result as conda for a chain of pure python source packages. |
Hi, maybe I've been too simplifying using https://hynek.me/articles/sharing-your-labor-of-love-pypi-quick-and-dirty/ Apparently Travis needs sometime a requirements.txt file reading https://caremad.io/blog/setup-vs-requirement/ indeed, on JuliaLang/pyjulia example https://travis-ci.org/JuliaLang/pyjulia/jobs/35193438 , a requirements.txt file is claimed
it's better after (even if only cosmetic) Maybe it's a false warning, even a bad idea, but as I fell over this, I point you to the documentation from Donald Stufft (the reference guy) |
Problem found, and not what I thought. Your setup check does "import matplotlib", which in recent version, needs "six" to be initialized.
==> "six" will be now part of my "priority install packages", so issue is fixed. |
Would it be possible to get a .whl universal package on Pypi ?
If I'm right, it's just a matter of adding a setup.cfg file at root level with
and then doing this to upload to pypi
Indeed, I'm getting an error when trying to use seaborn-0.4.0.tar.gz to build a winpython distribution
having a .whl package would probably remove my issue
(of repacking seaborn into a winpython distribution)
The text was updated successfully, but these errors were encountered: