Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data argument not used by format string #56

Closed
sbentzen opened this issue Jul 5, 2012 · 3 comments
Closed

data argument not used by format string #56

sbentzen opened this issue Jul 5, 2012 · 3 comments

Comments

@sbentzen
Copy link
Contributor

sbentzen commented Jul 5, 2012

Hey @mwaterfall,

noticed this bit of code doesn't use the data argument anywhere in the string or format being appended.
Should it just be pulled out? or is there something else that is to be accomplished?

if (ELEMENT_IS_EMPTY(elementName)) {
    [currentText appendFormat:@" />", elementName];
} else {
    [currentText appendFormat:@">", elementName];
}
@jsumners
Copy link

The static analyzer in Xcode 4.4.1 also catches this. I believe the block should be:

if (ELEMENT_IS_EMPTY(elementName)) {
  [currentText appendString:@" />"];
} else {
  [currentText appendString:@">"];
}

@sbentzen
Copy link
Contributor Author

I'll open a pull request later on today.

sbentzen pushed a commit to sbentzen/MWFeedParser that referenced this issue Aug 29, 2012
@mwaterfall
Copy link
Owner

This is now fixed on the master branch. Sorry for taking so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants