Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop cluster for Unix System #27

Open
milena-git opened this issue Jul 22, 2022 · 0 comments
Open

Stop cluster for Unix System #27

milena-git opened this issue Jul 22, 2022 · 0 comments

Comments

@milena-git
Copy link

Hello,

First thank you for this great package.

I am running GenericML functions in parallel on a Unix system, and I noticed that the requested cores remained so if I did not stopped my R session after use (on a shared rstudio-server). I was wondering whether they wasn't a parallel::stopCluster missing in the GenericML package code, and I found this line in the R/across-learner.R script:

## stop cluster (if applicable)
 if(win) parallel::stopCluster(cl = cl)

So it seems that it is on purpose that stopCluster is not run on Unix system, only on windows (I am not familiar with the parallel package and its requirement).

I wonder whether there is a reason for not stopping the cluster on Unix system after the GenericML function call. I guess it is best practice to stop its R session when done, but in my specific case, it can be sometimes annoying, therefore the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant