Todo list Add and remove items #2
Conversation
There was a problem hiding this comment.
Hi @mwenyoa
Good job so far! I know you have worked hard on making this milestone. There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- Check the comment under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!:clap::clap::clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Hi, @Emmyn5600 I am enable to see your required changes, kindly update me. |
|
Hello Emmy, I am unable to see any comments for the requested changes.
Kind regards,
Anthony.
…On Fri, Apr 29, 2022 at 5:09 PM Emmy NSABIMANA ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @mwenyoa <https://github.com/mwenyoa>
Good job so far! I know you have worked hard on making this milestone.
There are some issues that you still need to work on to go to the next
project but you are almost there!
[image: almost-there]
<https://user-images.githubusercontent.com/65068771/141811112-252360b9-757f-4279-bb3b-b7a2a4675ad3.gif>
Required Changes ♻️
- Check the comment under the review.
Optional suggestions
*Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.*
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
*Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.*
------------------------------
*As described in the Code reviews limits policy
<https://microverse.zendesk.com/hc/en-us/articles/1500004088561> you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form <https://airtable.com/shrQAqnBwek5a0O0s>.*
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG25NNBMNK3OF6I356BMPYDVHP3TLANCNFSM5UWIF7DA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@mwenyoa But I have attached the message and screenshot. |
There was a problem hiding this comment.
Hi @mwenyoa
Good job so far! I know you have worked hard on making this milestone. There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
- Check the comment under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!:clap::clap::clap:
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Project Under Second Opinion Review. |
There was a problem hiding this comment.
Hello @mwenyoa 👋,
This is an additional review as a result of the second opinion request.
Great work with the app so far. 👍🏽 I will explain the point raised by the CR and I hope you will understand it with this.
In the project requirements, specifically, the last point reads All changes to the To-Do List should be saved in local storage.. This implies that once the to-do is checked as true, this change has to be saved in the local storage and should persist on reloading the page.
Make the requested change and once you are ready, submit another CRR. 🙏🏽
Keep rocking 🚀 and Happy Coding 💻 !
There was a problem hiding this comment.
Hi @mwenyoa,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
The following features were implemented: