fix: throw on circular references

The most basic case; when an object references itself directly.
immerjs · Jan 21, 2019 · 9c6603e · 9c6603e
1 parent 9a2e756
commit 9c6603e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/immer.js b/src/immer.js
@@ -168,7 +168,11 @@ export class Immer {
 
         const {onAssign} = this
         const finalizeProperty = (prop, value, parent) => {
-            // Only `root` can be a draft in here.
+            if (value === parent) {
+                throw Error("Immer forbids circular references")
+            }
+
+            // The only possible draft (in the scope of a `finalizeTree` call) is the `root` object.
             const inDraft = !!state && parent === root
 
             if (isDraft(value)) {