feat: export isDraft function
#220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess you could do |
|
Should isDraft return true for a new object that was added to the draft
tree? Probably not?
Op vr 19 okt. 2018 20:51 schreef Alec Larson <notifications@github.com>:
… I guess you *could* do !!original(value) to get the same effect as
isDraft(value). WDYT?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#220 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhGWgridOMwKAB7C5-lNHy3oLlc4Nks5umh60gaJpZM4XiHLq>
.
|
|
@mweststrate "Just proxies" is the idea. LGTM? |
|
@aleclarson LGTM. Could you add some tests for both proxy and non proxied version? |
|
Are tests necessary? It's a very simple function: |
|
For regression against internal refactorings, yeah please provide a some
false and positive tests to protect against accidental mistakes.
Op zo 21 okt. 2018 12:34 schreef Alec Larson <notifications@github.com>:
… Are tests necessary? It's a very simple function: const isDraft = (value)
=> !!value && !!value[PROXY_STATE]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#220 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhCsXUlyDkHXpJx_qEpOYbzv_6U-Kks5unE2sgaJpZM4XiHLq>
.
|
|
Done! |
aleclarson
force-pushed
the
isDraft
branch
2 times, most recently
from
75d6f82
to
f2b3e4b
Compare
aleclarson
added a commit
that referenced
this pull request
Oct 28, 2018
aleclarson
added a commit
that referenced
this pull request
Oct 28, 2018
migueloller
pushed a commit
to migueloller/immer
that referenced
this pull request
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use in other libraries