fix: reset bili.config, add Map getter for DRAFT_STATE, make isEnumerable more resilient #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able more resilient
aleclarson
approved these changes
Apr 18, 2019
src/common.js
Outdated
| @@ -109,7 +109,8 @@ export function each(value, cb) { | |||
| } | |||
|
|
|||
| export function isEnumerable(base, prop) { | |||
| return Object.getOwnPropertyDescriptor(base, prop).enumerable | |||
| const descriptor = Object.getOwnPropertyDescriptor(base, prop) | |||
| return descriptor && descriptor.enumerable | |||
There was a problem hiding this comment.
Was this causing a crash? I don't think we ever pass a property that doesn't exist. Or is this just for posterity?
There was a problem hiding this comment.
The descriptor is going to be undefined for Maps here https://github.com/immerjs/immer/blob/v3.1/src/immer.js#L288
| @@ -185,6 +185,7 @@ const mapTraps = { | |||
| } | |||
| } | |||
| const mapGetters = { | |||
| [DRAFT_STATE]: state => state, | |||
There was a problem hiding this comment.
Ah, thanks for catching this!
There was a problem hiding this comment.
Np. Thanks for refactoring the whole thing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.