Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS conversion #484

Merged
merged 10 commits into from Dec 20, 2019
Merged

TS conversion #484

merged 10 commits into from Dec 20, 2019

Conversation

mweststrate
Copy link
Collaborator

@mweststrate mweststrate commented Dec 18, 2019

No description provided.

@@ -3,6 +3,7 @@
"compilerOptions": {
"lib": ["es2015"],
"strict": true,
"declaration": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egoist any idea why this breaks bili? (see error above in commit message of 4377dcd)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, forgot to bump versions first. Latest version fixes it.

…/mweststrate/Desktop/immer/node_modules/.bin/bilierror Failed to bundle src/index.ts in cjs formatStack Trace:TypeError: this.emitFile is not a function at emitDeclaration (/Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:27461:26) at lodash_3 (/Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:27469:17) at /Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:4923:15 at baseForOwn (/Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:3008:24) at /Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:4892:18 at forEach (/Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:9360:14) at Object._onwrite (/Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:27468:13) at Object.generateBundle (/Users/mweststrate/Desktop/immer/node_modules/rollup-plugin-typescript2/dist/rollup-plugin-typescript2.cjs.js:27402:27) at /Users/mweststrate/Desktop/immer/node_modules/rollup/dist/rollup.js:17067:25error Command failed with exit code 1.```
@mweststrate mweststrate changed the title [WIP] TS conversion TS conversion Dec 20, 2019
@mweststrate
Copy link
Collaborator Author

Can be tried using 5.1.0-beta.1

@mweststrate mweststrate merged commit 52c9914 into master Dec 20, 2019
@aleclarson
Copy link
Member

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants