Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enable sourcemaps and declaration maps in tsconfig.json #490

Merged
merged 1 commit into from Dec 23, 2019

Conversation

justingrant
Copy link
Contributor

Fixes #489 by enabling sourcemaps in tsconfig.json.

While we're in the neighborhood, this PR also enables declaration maps, which are auto-generated sourcemaps for .d.ts files. Declaration maps enable the "Go To Definition" (F12) feature of VSCode, CodeSandbox, and other IDEs to navigate to the actual immer implementation code. Without declaration maps, the user only can only navigate to the .d.ts file when "Go To Definition" is used.

@mweststrate
Copy link
Collaborator

Awesome, thanks! Do you know whether this also fixes the weirdly generated reference to tslib? (See #487)

@mweststrate mweststrate merged commit fb70772 into immerjs:master Dec 23, 2019
@justingrant
Copy link
Contributor Author

Do you know whether this also fixes the weirdly generated reference to tslib? (See #487)

Nope, unfortunately. I couldn't figure out the cause of that tslib thing. See my comment on #487

@aleclarson
Copy link
Member

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

immer source filenames are missing from V5.1.0 sourcemaps
3 participants