Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rollup to build process #64

Merged

Conversation

arthurdenner
Copy link
Contributor

Hi, @mweststrate.

So, I took a deeper look at microbundle and it seems to not be generating sourcemaps, so I decided to take a chance at building a rollup config myself. Here is my attempt. 馃槄

If you don't want sourcemaps, I think we can stick with microbundle.

However, to fix #46, I believe we'll need this plugin and I don't if it's possible and/or how to add it to microbundle configuration.

PS: I 'm pretty sure this config can be improved, I just don't know how at the moment. If you know how, please let me know. First time using rollup here. 馃槄

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.101% when pulling c3e1148 on arthurdenner:adding-rollup-to-build-process into cb4daee on mweststrate:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.101% when pulling b2d42b9 on arthurdenner:adding-rollup-to-build-process into cb4daee on mweststrate:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.101% when pulling a420176 on arthurdenner:adding-rollup-to-build-process into cb4daee on mweststrate:master.

@mweststrate
Copy link
Collaborator

Thanks! will review in a few days! First want to fix the code reuse between the two immer implementations

@mweststrate
Copy link
Collaborator

I have another PR with probably some conflicting changes, so gonna merge this one, and process the final changes there. Thanks for the PR!

@mweststrate mweststrate merged commit e70fd42 into immerjs:master Jan 16, 2018
@arthurdenner arthurdenner deleted the adding-rollup-to-build-process branch January 16, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support NODE_ENV='production' substitution to turn of auto-freeze
3 participants