Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support frozen objects #107

Merged
merged 1 commit into from
Feb 1, 2016
Merged

Support frozen objects #107

merged 1 commit into from
Feb 1, 2016

Conversation

andykog
Copy link
Member

@andykog andykog commented Jan 31, 2016

This code:

var arr = mobservable.observable([]);
var person = Object.freeze({ name: 'bob' })
arr.push(person)

throws error Cannot define property:$mobservable, object is not extensible.

This also prevents from pushing react elements into mobservable array:

buttons.push(<button title="test" />);

@mweststrate
Copy link
Member

Thanks for the addition!

mweststrate added a commit that referenced this pull request Feb 1, 2016
@mweststrate mweststrate merged commit 702e6ef into mobxjs:master Feb 1, 2016
@mweststrate
Copy link
Member

Released as part of version 1.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants