Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[似合い] Request: order similar Kanji by level/availability #22

Open
marciska opened this issue Jan 13, 2023 · 2 comments · May be fixed by #34
Open

[似合い] Request: order similar Kanji by level/availability #22

marciska opened this issue Jan 13, 2023 · 2 comments · May be fixed by #34

Comments

@marciska
Copy link

Right now, the list of similar Kanji feels rather random.
Kanji that are not yet unlocked are mixed between Kanjis that have been already learned.
This results in big eye jumps especially on large screens, making it a bit harder to spot differences between Kanji.

Proposal

Order list to show already learned items first, then locked ones after.
I can think of 2 ways:

  1. check if Kanji is yet unlocked, and if not, put it at the end
  2. order by WaniKani-level
@marciska marciska changed the title Request: order similar Kanji by level/availability [似合い] Request: order similar Kanji by level/availability Jan 13, 2023
@mwil
Copy link
Owner

mwil commented Jan 16, 2023

Currently, the kanji are sorted by a "similarity score", so the ones one the left should be the easiest to confuse. I'm not against moving the not yet unlocked ones to the end, but ordering by WK level would break the "pin kanji of your choice to the top" functionality, because atm it just adds a big boost to the score.

@marciska
Copy link
Author

You are right. I made a pull request a while ago, but changed it now according to your suggestion. Sorting into two groups of (A: unlocked Kanji, B: locked Kanji), and sorting both groups by their score rather than their level makes more sense to me.
In any way, the gaps between kanji I learned and have not yet learned are quite distracting for me, but I'm happy to accept everyone else's opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants