Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correct preact-compat reference in the ReadMe #3

Merged
merged 1 commit into from May 18, 2022
Merged

docs: Correct preact-compat reference in the ReadMe #3

merged 1 commit into from May 18, 2022

Conversation

rschristian
Copy link
Contributor

@rschristian rschristian commented May 18, 2022

Small typo.

preact-compat is the legacy compat, only used in Preact 8 and older. As this project has a peer dependency on Preact > 10. definitely need to be using preact/compat.

Looks really cool btw!

@netlify
Copy link

netlify bot commented May 18, 2022

Deploy Preview for preact-island ready!

Name Link
🔨 Latest commit c3d6470
🔍 Latest deploy log https://app.netlify.com/sites/preact-island/deploys/6284739136750a0008c45c9c
😎 Deploy Preview https://deploy-preview-3--preact-island.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mwood23
Copy link
Owner

mwood23 commented May 18, 2022

@rschristian Good catch! Thanks for the PR, just added the React island docs actually in #4 so it'll be good to have it updated

@mwood23 mwood23 merged commit bd7a489 into mwood23:master May 18, 2022
@rschristian rschristian deleted the rschristian-patch-1 branch May 18, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants