Check if requests is installed?

[Anselmoo]

If requests is not pre-installed, the native installation (pip install .) can cause some trouble.

itables/setup.py

Line 6 in d12e364

import requests

It might be a good idea to catch that via try-except?

Solution 1:

try:
    import requests
except ImportError:
    print("Please install requests")
    exit(1)

Solution 2:

try:
    import requests
except ImportError:
    import subprocess
    subprocess.check_call(['python', '-m', 'pip', 'install', 'requests'])
    import requests

[mwouts]

Hey @Anselmoo , maybe we could use a build requirement like documented here: https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#build-system-requirement ? As requests is only used when the package is built... What do you think?

[Anselmoo]

That's an excellent idea!

However, pyproject.toml should also be considered used as a replacement for setup.py in the long term.

See also: https://github.com/pandas-dev/pandas/blob/main/pyproject.toml

[Anselmoo]

@mwouts looks like it works, however I have to also fix the flake8 issue #124