-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition ITables to the src
layout
#246
Comments
If you want to use
Basically that is how most of JupyterLab packages are organized. Then you will have to move the transpiled You can keep Does it make sense to you? |
Thanks @mahendrapaipuri! Yes that makes perfect sense. I'll give this a try over the week-end, thanks for the advice! |
Hi @mahendrapaipuri, just tried something but the CI is pretty red so far 😉 I guess I am not sure how to implement move the transpiled js assets in the Also, re the |
This needs to be done in build script in
With such
This is another way of doing it as well if you would like to distribute I think a sensible approach is to distribute these files with package just like you are doing now (so that you dont need to do any major changes in src code) and once |
Thanks @mahendrapaipuri ! That's perfectly clear. I like the use of multiple scripts that will let me continue to build the |
I think I am seeing a first version of this working! Thanks @mahendrapaipuri! |
In prevision of #245 I would like to transition ITables to the
src
layout.@mahendrapaipuri do you think you could give me a hand on this?
This is what I am wondering:
dt_for_itables
node package go? Currently it is atitables/dt_for_itables
, should I move it atsrc/dt_for_itables
? Or at the root of the project? Note that the Python package usesdt_bundle.js
anddt_bundle.css
that are created by that packagesrc/itables_for_dash
folder with more or less this content (e.g. a node package, a Python package, and optionally a R and Julia package)? Or should I move that somewhere else? I would much prefer not to create another repo for that.html
folder currently withinitables
(with the html table template) at some other location, or is the current location fine?The text was updated successfully, but these errors were encountered: