Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown conversion: metadata conversion issue #383

Closed
chrisjsewell opened this issue Nov 12, 2019 · 3 comments · Fixed by #385
Closed

Markdown conversion: metadata conversion issue #383

chrisjsewell opened this issue Nov 12, 2019 · 3 comments · Fixed by #385
Milestone

Comments

@chrisjsewell
Copy link
Contributor

Heya, using version 1.3.0rc1, code cell with metadata of the form:

{"a": "b, c", "d": "e" }

Is converted to:

    ```{python a=b, c, d=e}
    ```

I'm guessing the strings should be quoted?

And if not, this causes a round trip error:

Unreadable Notebook: /.../Untitled.Rmd RMarkdownOptionParsingError('Option line "a=b, c, d=e" has no name for option value c',)
@mwouts
Copy link
Owner

mwouts commented Nov 13, 2019

Indeed! Thanks @chrisjsewell for reporting this. I'll have a look.

@mwouts mwouts added this to the 1.3.0 milestone Nov 14, 2019
@mwouts
Copy link
Owner

mwouts commented Nov 14, 2019

Hello @chrisjsewell , could you give a try to the latest RC?

pip install jupytext==1.3.0rc2

Also, @grst , do you mind to test it as well? I'd like to make sure that you're not affected.

@grst
Copy link
Contributor

grst commented Nov 14, 2019

Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants