Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give better error messages on failed download #7

Closed
bcipolli opened this issue Jun 25, 2019 · 2 comments
Closed

Give better error messages on failed download #7

bcipolli opened this issue Jun 25, 2019 · 2 comments
Milestone

Comments

@bcipolli
Copy link

There are a number of metrics that fail to download. Some give a meaningful error ("400 bad request", with URL printed), while others give a cryptic "Expecting value: line 1 column 1 (char 0)".

Instead of printing cryptic errors, handle more gracefully.

@mwouts
Copy link
Owner

mwouts commented Jun 25, 2019

Hello @bcipolli , sure, that is a great idea!
Could you please provide a sample code snippet that produces that error?
I'd be interesting in fixing both the error message, and if possible, the download itself.

@mwouts mwouts added this to the 0.1.3 milestone Jul 5, 2019
@mwouts
Copy link
Owner

mwouts commented Jul 5, 2019

I plan to release an update of the package soon. Would you like to contribute an example that produces the error? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants