Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename theme specific assets #423

Closed
mwskwong opened this issue Jun 20, 2024 · 0 comments
Closed

Rename theme specific assets #423

mwskwong opened this issue Jun 20, 2024 · 0 comments
Assignees
@mwskwong
Labels
enhancement New feature or request

Comments

@mwskwong
Copy link
Owner

Current

logo-light.svg means the logo has light colors and is suitable to be placed on dark bg.

However in <Image>, srcLight means it will be used on a light theme, i.e. light bg.

Expected

Rename logo-light.svg to logo-dark.svg and vice versa, so align with the meaning of srcLight and srcDark`.
@mwskwong mwskwong added the enhancement New feature or request label Jun 20, 2024
@mwskwong mwskwong self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwskwong mwskwong

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwskwong