This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Examples of Gradle projects. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mwz, This looks perfect to me. However there is a small detail, I noticed you created a .gitignore file in the examples folder. Wouldn't it be better to have one per example? (or at least one per technology e.g. sbt, gradle, mvn). |
|
Yeah, that's a fair point - addressed in 887ef6c. |
Thanks, for me it is ready to be merged now. |
|
Excellent, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a single-module and multi-module projects.
I also removed the existing sbt and maven examples as those were no longer up to date and they need to be updated, but this will be done in separate PRs - tracked in #41.