Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute parsing in SP of SAML response doesn't support FriendlyName or multiple values #24

Open
j00bar opened this issue May 27, 2020 · 0 comments
Open

Attribute parsing in SP of SAML response doesn't support FriendlyName or multiple values #24

j00bar opened this issue May 27, 2020 · 0 comments

Comments

@j00bar
Copy link

j00bar commented May 27, 2020

Howdy!

Happy to contribute a PR to support this, but it seems like the ResponseParser.attributes property could be improved in two ways:

  1. If the SAML Attribute has a FriendlyName, it should be preferred over the Name - otherwise you get things like urn:oid:2.5.4.42 as a key versus givenName.
  2. If there are multiple Attribute elements with the same name, only the first one appears in the attributes property, whereas some SAML assertions include multiple Role attributes.

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@j00bar