Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

When Constructing Models, Prefer Defaults and Logging to Exceptions #168

Closed
mxashlynn opened this issue Apr 29, 2020 · 1 comment
Closed

When Constructing Models, Prefer Defaults and Logging to Exceptions #168

mxashlynn opened this issue Apr 29, 2020 · 1 comment
Assignees
@mxashlynn
Labels
Feature Feature or feature-enhancement request.
Milestone
Future Features

Comments

@mxashlynn
Copy link
Owner

It seems like rather than the library throwing an exception when a model is constructed from invalid data, it should instead construct a default model and log an error silently.

This is not something I want to do for 1.0, but I did want to leave a public note saying it's something I I'd like to implement post 1.0.
@mxashlynn mxashlynn added the Feature Feature or feature-enhancement request. label Apr 29, 2020
@mxashlynn mxashlynn added this to the Scope Creep milestone Apr 29, 2020
@mxashlynn mxashlynn self-assigned this Apr 29, 2020
@mxashlynn
Copy link
Owner Author

Done! The entire library now prefers logging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mxashlynn mxashlynn

Labels
Feature Feature or feature-enhancement request.
Projects
None yet
Milestone
Future Features
Development

No branches or pull requests
1 participant
@mxashlynn