makensis failed to build on 10.9 (13A603)

[jodygarnett]

After updating to 10.9 makensis no longer builds, this worked in the previous OS X release. I would like to determine if this is an environmental difference that can be addressed in home-brew, or something I should report to the NSIS project.

==> scons makensis
int close(int) __DARWIN_ALIAS_C(close);
^
1 error generated.
scons: *** [build/release/makensis/script.o] Error 1
scons: building terminated because of errors.

Long form output requested by issue reporting process (brew doctor etc...):

https://gist.github.com/jodygarnett/7286977

Detailed log reported by: brew gist-logs --config --doctor makensis output:

https://gist.github.com/anonymous/7286964

[jodygarnett]

Reported build issue to NSIS:

https://sourceforge.net/p/nsis/bugs/1085/

[jodygarnett]

I checked that headers were available /usr/include/unistd.h contains:

int  close(int) __DARWIN_ALIAS_C(close);

I have tried reinstalling command line tools as per discussion here: http://clang-developers.42468.n3.nabble.com/Naive-Mavericks-Trunk-Build-Errors-td4035480.html

[allengeorge]

Have you tried adding unistd.h as a header to Source/util.h?

[jodygarnett]

Apparently in 10.9 clang compiler has changed its default std lib from libstdc++ to libc++

Details here: https://jira.mongodb.org/browse/SERVER-10644

I would like to try and add the compile option -stdlib=libstdc++ but I am not sure where.

[jodygarnett]

Thanks for the suggestion allengeorge - I modified util.h and have a build. Not sure how that helps home-brew but still.

The result fails to run:

Error: opening stub "/usr/local/share/nsis/Stubs/zlib"
Error initalizing CEXEBuild: error setting default stub

[jodygarnett]

Alternative that made a bit of progress, update formulate to have:

scons APPEND_CCFLAGS=--stdlib=libstdc++ makensis

The build gets further and then fails with link errors.

[kridgeway]

@jodygarnett
clang needs the --stdlib=libstdc++ linker flag too:

scons makensis APPEND_CCFLAGS=--stdlib=libstdc++ APPEND_LINKFLAGS=--stdlib=libstdc++

The above worked for me!

[jodygarnett]

That worked for me as well! Thank you!

[jodygarnett]

So do we do a pull request or something to contribute this back?

[adamv]

Yes, please make a pull request.

[jodygarnett]

See pull request: #24545

[mistydemeo]

Pushed a fix for this - thanks for the report!