Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

libplist: Update to 1.10, enable Cython bindings #18691

Closed
wants to merge 1 commit into from
Closed

libplist: Update to 1.10, enable Cython bindings #18691

wants to merge 1 commit into from

Conversation

aried3r
Copy link
Contributor

@aried3r aried3r commented Mar 24, 2013

  • Added HEAD
  • Update to version 1.10 from 1.8
  • Removed unnecessary CMakeLists.txt patch (now done via options)
  • Removed other now unnecessary patches
  • Added --python option for Cython Python bindings
  • Added Caveat
  • Added fix for CMake from opencv.rb
  • Removed libxml2 dependency, provided by OS X

Related to #18396

Hope the libxml2 part is ok. I read here that it's ok to use depends_on in this case, but also here that homebrew tries not to duplicate dependencies.

PS: The new binary is called plistutil

@cooljeanius
Copy link

This corresponds to the following MacPorts ticket: https://trac.macports.org/ticket/38520

Edit: which was committed in r104408

@samueljohn
Copy link
Contributor

Cool. Can you name the python option --with-python? Would be more consistent.

@aried3r
Copy link
Contributor Author

aried3r commented Mar 25, 2013

I made the changes mentioned by @adamv and @samueljohn. Please re-verify.

@samueljohn
Copy link
Contributor

One thing bothers me

CMake Warning:
  Manually-specified variables were not used by the project:

    PYTHON_PACKAGES_PATH

Looks like this var is ignored and was specific to OpenCV.

With a brewed python (and after I did pip install cython of course) this works. Could you test with system python, too? Perhaps it works and is sufficient to set the PYTHONPATH variable.

@samueljohn
Copy link
Contributor

If you get it working with system python, perhpas we don't need PYTHON_PACKAGES_PATH and can remove it. Then I'll pull in. Thanks for all the work here!

@aried3r
Copy link
Contributor Author

aried3r commented Mar 26, 2013

Removed PYTHON_PACKAGES_PATH. Builds with brewed and system Python on OS X 10.8.3.

@samueljohn
Copy link
Contributor

ok

@samueljohn
Copy link
Contributor

Thanks very much. Visit us again :-)

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants