Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Update spatialite-gui to 1.7.1 and libspatialite to 4.1.1 #21110

Closed
wants to merge 1 commit into from

Conversation

dakcarto
Copy link
Contributor

  • spatialite-gui 1.7.x requires libspatialite to be built with libxml2 support

( https://groups.google.com/d/msg/spatialite-users/h8bdWISBhIQ/57m9wHfKCVoJ )

@jacknagel
Copy link
Contributor

Is the system libxml2 not sufficient?

@dakcarto
Copy link
Contributor Author

Hi,

Probably, but not entirely sure. I still have some SnoLeo Macs here at work and will test that out (as a baseline) today. I'll look at configure script and verify versioning as well.

@jacknagel
Copy link
Contributor

Thanks.

@dakcarto
Copy link
Contributor Author

@jacknagel this is my first foray into recipe editing, so please review. (I have rebased mxcl/master recent commits in and force pushed my changes to my branch)

About the OS X system libxml2:

  • On 10.7.5, libspatialite compiled; then spatialite-gui configured, but failed to compile with errors about undefined symbols. Using homebrew's libxml2 fixed the compilation.
  • On 10.6.8, system libxml2 is compiled against Python 2.6, and throws an error. Using homebrew's libxml2 allowed successful compilation of both libspatialite and spatialite-gui.
  • In both cases, spatialite-tools compilation was unaffected.

About XCode 4.6+ edits: on my 10.7.5 Mac using XCode 4.6.3 with default compilers, both libspatialite and spatialite-gui failed to pick up the pkg-config setups for libgiagraphics, freexl, libspatialite and libxml2. Added some env variables to fix configure of both. Unneeded with tested XCode 4.5.x and 3.2.x.

The XCode 4.6+ edits may need verified, since I only tested them on one Mac with that setup. Can test it on another Mac when I get home tonight.

@dakcarto
Copy link
Contributor Author

btw: Jenkins CI bot is failing because http://www.gaia-gis.it/gaia-sins/ (spatialite server) seems to be unreachable at the moment

ENV.append 'PKG_CONFIG', "#{HOMEBREW_PREFIX}/bin/pkg-config"
ENV.append 'PKG_CONFIG_PATH', "-I#{libxml.opt_prefix}/lib/pkgconfig"
end
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done automatically if you add depends_on 'pkg-config' => :build to the formula

@dakcarto
Copy link
Contributor Author

@jacknagel Turns out that libxml2 does not need Python support at all for spatialite-gui (by way of libspatialite libxml2-linked symbols). Dropped the with-python option and updated the pkg-config as you noted (worked great). Much cleaner, simpler now.

I think this should be squashed down to one commit after testing on 10.6.8 again.

@dakcarto
Copy link
Contributor Author

OK, does clean installs of libxml2, libspatialite, spatialite-tools and spatialite-gui fine on 10.7.5 and 10.6.8 (now using libxml2 --without-python).

Not tested on 10.8.x, but waiting on build bot.

@jacknagel
Copy link
Contributor

Great, thanks for your diligence here.

@adamv adamv closed this in cba7342 Jul 12, 2013
handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013
Closes Homebrew#21110.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
@dakcarto dakcarto deleted the spatialite-update branch November 21, 2013 21:23
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants