Update spatialite-gui to 1.7.1 and libspatialite to 4.1.1 #21110
Conversation
Is the system libxml2 not sufficient? |
Hi, Probably, but not entirely sure. I still have some SnoLeo Macs here at work and will test that out (as a baseline) today. I'll look at configure script and verify versioning as well. |
Thanks. |
@jacknagel this is my first foray into recipe editing, so please review. (I have rebased mxcl/master recent commits in and force pushed my changes to my branch) About the OS X system libxml2:
About XCode 4.6+ edits: on my 10.7.5 Mac using XCode 4.6.3 with default compilers, both libspatialite and spatialite-gui failed to pick up the pkg-config setups for libgiagraphics, freexl, libspatialite and libxml2. Added some env variables to fix configure of both. Unneeded with tested XCode 4.5.x and 3.2.x. The XCode 4.6+ edits may need verified, since I only tested them on one Mac with that setup. Can test it on another Mac when I get home tonight. |
btw: Jenkins CI bot is failing because http://www.gaia-gis.it/gaia-sins/ (spatialite server) seems to be unreachable at the moment |
ENV.append 'PKG_CONFIG', "#{HOMEBREW_PREFIX}/bin/pkg-config" | ||
ENV.append 'PKG_CONFIG_PATH', "-I#{libxml.opt_prefix}/lib/pkgconfig" | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done automatically if you add depends_on 'pkg-config' => :build
to the formula
@jacknagel Turns out that libxml2 does not need Python support at all for spatialite-gui (by way of libspatialite libxml2-linked symbols). Dropped the with-python option and updated the pkg-config as you noted (worked great). Much cleaner, simpler now. I think this should be squashed down to one commit after testing on 10.6.8 again. |
OK, does clean installs of libxml2, libspatialite, spatialite-tools and spatialite-gui fine on 10.7.5 and 10.6.8 (now using libxml2 --without-python). Not tested on 10.8.x, but waiting on build bot. |
Great, thanks for your diligence here. |
Closes Homebrew#21110. Signed-off-by: Adam Vandenberg <flangy@gmail.com>
( https://groups.google.com/d/msg/spatialite-users/h8bdWISBhIQ/57m9wHfKCVoJ )