Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Enable Python bindings in vte formula. #23917

Closed
wants to merge 9 commits into from
Closed

Enable Python bindings in vte formula. #23917

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
73603cf
Enable Python bindings in vte formula.
Nov 3, 2013
9c178a3
Fix trailing whitespace.
Nov 3, 2013
690389b
vte formula now does not assume location of pygobject-codegen-2.0
adamtheturtle Nov 4, 2013
5894e4b
Addressed review comments
adamtheturtle Mar 31, 2014
4680eb1
Addressed review comments
adamtheturtle Mar 31, 2014
4d3dd26
Improve comment
adamtheturtle Apr 3, 2014
e59741b
Python dependency is not recommended
adamtheturtle Apr 11, 2014
4ff0bb6
Only "--enable-python" if `build.with? "python"`
adamtheturtle Apr 11, 2014
9999a15
Moved some code into `if build.with? "python"`
adamtheturtle Apr 11, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 16 additions & 4 deletions Library/Formula/vte.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,24 @@ class Vte < Formula
depends_on 'gettext'
depends_on 'glib'
depends_on 'gtk+'
depends_on 'pygtk'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last quick thing: this should probably have depends_on :python if it's building Python bindings. Sorry for not saying it earlier.

depends_on :python => :recommended

def install
system "./configure", "--disable-dependency-tracking",
"--prefix=#{prefix}",
"--disable-python",
"--disable-Bsymbolic"
args = [
"--disable-dependency-tracking",
"--prefix=#{prefix}",
"--disable-Bsymbolic",
]

if build.with? "python"
# pygtk-codegen-2.0 has been deprecated and replaced by
# pygobject-codegen-2.0, but the vte Makefile does not detect this.
ENV["PYGTK_CODEGEN"] = Formula["pygobject"].bin/'pygobject-codegen-2.0'
args << "--enable-python"
end

system "./configure", *args
system "make install"
end
end