Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to rely on the polling mechanism on all platforms #4

Closed
rklaehn opened this issue Dec 3, 2020 · 1 comment
Closed

Comments

@rklaehn
Copy link

rklaehn commented Dec 3, 2020

This might be a good short term solution until the added headers have made their way to musl. See #3

But independent of this, this might also be a nice thing to have for obscure platforms.

The idea would be to have a feature flag that disables all the fancy stuff and just relies on the polling mechanism, which should be working on more platforms. This may or may not be a good idea, you decide.

@dvc94ch
Copy link
Collaborator

dvc94ch commented Dec 3, 2020

We already do this for all targets that aren't linux/windows. The problem in #3 is unfortunate, but it will be fixed for all current and future musl targets.

@dvc94ch dvc94ch closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants